jkleinsc

#49936: build: exit upload with error code if github upload fails

Merged
Created: Feb 24, 2026, 3:53:32 PM
Merged: Feb 25, 2026, 7:16:14 AM
5 comments
Target: main

Description of Change

It turns out that we were not properly failing release builds when we fail to upload an asset to GitHub. This PR updates our release logic to fail the build if any assets fail to upload to GitHub.

Checklist

Release Notes

Notes: none

Backports

38-x-y
Merged
PR Number
#
Merged At
Released In
Not yet
Release Date
Not yet
39-x-y
Merged
PR Number
#
Merged At
Released In
Not yet
Release Date
Not yet
40-x-y
Merged
PR Number
#
Merged At
Released In
Not yet
Release Date
Not yet
41-x-y
Merged
PR Number
#
Merged At
Released In
Not yet
Release Date
Not yet

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron